Max/sdk streamer #6129
Max/sdk streamer #6129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
you might want to rebase it first : ) |
common/client-core/src/lib.rs
Outdated
| @@ -1,3 +1,4 @@ | |||
| #![allow(deprecated)] | |||
There was a problem hiding this comment.
just for the reference, what's deprecated there?
There was a problem hiding this comment.
it removes the clippy err for: warning: use of deprecated associated function nym_crypto::generic_array::GenericArray::<T, N>::clone_from_slice: please upgrade to generic-array 1.x - I will add in a comment on the allow(deprecated)s what is being ignored. Followed Drazen's advice to ignore instead of start messing with the crypto crate on this PR.
| // Copyright 2022 - Nym Technologies SA <[email protected]> | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| #![allow(deprecated)] |
There was a problem hiding this comment.
just for the reference, what's deprecated there?
There was a problem hiding this comment.
I'm going to stop putting this under every single instance. this comment applies to all of those : )
There was a problem hiding this comment.
added the compiler warning (that becomes a clippy err) that each of these fixes to the ones i've added in this PR
| } | ||
|
|
||
| /** | ||
| * Functions below are from the nym-connection-monitor crate. |
There was a problem hiding this comment.
again, couldn't we just use the crate directly (since it's in the monorepo) rather than duplicating the non-trivial code?
| } | ||
|
|
||
| pub async fn handle_reconstructed_message( | ||
| &mut self, |
There was a problem hiding this comment.
why does it need to be mutable given IprListener literally doesn't have anything on it?
| pub fn rx_receiver(&self) -> mpsc::UnboundedReceiver<Vec<u8>> { | ||
| // Create a new channel and return the receiver | ||
| // This is a bit of a hack but necessary for the current architecture | ||
| let (_tx, rx) = mpsc::unbounded_channel(); |
There was a problem hiding this comment.
wait. what's the point of a channel that's immediately getting closed?
| let proto = packet[9]; | ||
| let src_ip = &packet[12..16]; | ||
| let dst_ip = &packet[16..20]; | ||
| info!( |
| info!( | ||
| "Outgoing IPv{} packet: proto={}, src={}.{}.{}.{}, dst={}.{}.{}.{}", | ||
| version, proto, | ||
| src_ip[0], src_ip[1], src_ip[2], src_ip[3], |
There was a problem hiding this comment.
well, those logs will only work if it's an ipv4 packet
benedettadavico
modified the milestones:
Leerdammer (est. mainnet 11.11.2025),
Mozzarella (est. mainnet 25.11.2025)
This PR grew a bit, it includes:
mixtcp, asmoltcpdevice that uses the IPR abstraction for transport. this proof of concept has several example files showing how it can be used for HTTPS requests and doing TLS handshakes via the Mixnet.Documentation will be done in a separate PR.
ToDo:
developThis change is